Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object types for Nayms objects #86

Merged
merged 10 commits into from
Oct 25, 2023
Merged

Object types for Nayms objects #86

merged 10 commits into from
Oct 25, 2023

Conversation

kevin-fruitful
Copy link
Contributor

@kevin-fruitful kevin-fruitful commented Oct 19, 2023 •
edited
Loading

A type system for all Nayms objects, currently including:

  • Address
  • Entity
  • Policy
  • Claim
  • Dividend
  • Role
  • Group

@kevin-fruitful
Copy link
Contributor Author

Task linked: CU-8692z9rmb Add object types

@kevin-fruitful
Copy link
Contributor Author

Task linked: CU-8692z9twt Add object types

@kevin-fruitful kevin-fruitful marked this pull request as ready for review October 25, 2023 08:44
amarinkovic
amarinkovic approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@amarinkovic amarinkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I like how you kept it encapsulated in the tests, changes are minimal.

@kevin-fruitful kevin-fruitful merged commit e651557 into dev Oct 25, 2023
4 checks passed
@kevin-fruitful kevin-fruitful deleted the object_types branch October 25, 2023 09:28
@amarinkovic amarinkovic mentioned this pull request Oct 25, 2023
Merged
@amarinkovic amarinkovic changed the title Object types for Nayms objects Object types for Nayms objects [CU-8692uccju] Oct 25, 2023
@amarinkovic amarinkovic changed the title Object types for Nayms objects [CU-8692uccju] Object types for Nayms objects Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarinkovic amarinkovic amarinkovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevin-fruitful @amarinkovic