Fix claim payments post maturation #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
amarinkovic
changed the title
kevin-fruitful
approved these changes
Oct 30, 2023
amarinkovic
force-pushed
the
IM-25127_pay_claim_post_maturation
branch
from
06af514 to
97a1aba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Claims can be paid out even after policy has matured. This causes an underflow.
Solution is not to update locked balance and entity utilisation rate in such case. Payment is done only if there is enough balance available. Locked funds cannot be used for this.
Bug was discovered analysing this Immunefi report: IM-25127