-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extendable diamond cut #96
Conversation
13976e5
to
5323fb7
Compare
0bdf481
to
782a3b3
Compare
This change is currently constrained by the gemforge DiamondProxy generation code. There is no way to specify a custom Current version generates a constructor call like this: constructor(address _contractOwner) payable Diamond(_contractOwner, address(new DiamondCutFacet())) { Ideally, it would be possible to generate the constructor(address _contractOwner) payable Diamond(_contractOwner, address(new PhasedDiamondCutFacet())) @hiddentao do you think this might be a feature worth including? I guess there could be a config property one could set to override the default implementation. |
1d2edf2
to
3a30f1b
Compare
Yeah, this is something that could be investigated for Gemforge > gemstation/gemforge#38 |
3a30f1b
to
1331b83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one minor comment. Looks fine otherwise ~
LGTM |
Builds up on the upstream implementation of
DiamondCutFacet
, extending it with custom code for governance. The idea here is that we only add in custom code before calling the super implementation.