-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Self-Onboarding #97
Merged
Merged
Self-Onboarding #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarinkovic
requested review from
hiddentao,
kevin-fruitful and
tgeorgas
and removed request for
hiddentao
January 19, 2024 15:19
amarinkovic
force-pushed
the
self_onboarding
branch
2 times, most recently
from
January 23, 2024 10:40
cff824b
to
836caca
Compare
amarinkovic
force-pushed
the
self_onboarding
branch
from
January 25, 2024 10:28
836caca
to
0fb6c3f
Compare
amarinkovic
force-pushed
the
self_onboarding
branch
from
January 29, 2024 11:04
047564b
to
3ea5e7c
Compare
kevin-fruitful
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left 2 comments for review ~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to streamline the onboarding process and provide better user onboarding experience, users should be able to self-onboard, once the KYC process has been successfully completed and wallet is associated with their account.
Dedicated role:
Onboarding Approvers
will be used to perform these approvals. OnlySystem Manager
is the one who assigns accounts to this group.Once KYC is complete, wallet gets approved for onboarding and the user can then onboard them self. Only two roles that should be approved for self-onboarding are:
Capital Provider
Token Holder