Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor filter modules and make them reusable #113

Merged
merged 18 commits into from
Mar 20, 2024
Merged

Conversation

Flo0807
Copy link
Collaborator

@Flo0807 Flo0807 commented Feb 19, 2024

Refactoring of the filter modules to make them more reusable and prevent dialyzer warnings. Moved most of the functions outside the quote block.

@Flo0807 Flo0807 marked this pull request as draft February 19, 2024 11:28
@Flo0807 Flo0807 force-pushed the feature/improve-filter branch from 5d6a659 to 8e9249e Compare February 19, 2024 11:31
@Flo0807 Flo0807 changed the title Make filter reusable Refactor filter modules and make them reusable Feb 19, 2024
@Flo0807 Flo0807 added the enhancement Changes that are not breaking label Feb 19, 2024
@Flo0807 Flo0807 requested review from pehbehbeh and krns February 19, 2024 12:57
@Flo0807 Flo0807 marked this pull request as ready for review February 19, 2024 12:57
@Flo0807 Flo0807 added breaking-change A breaking change and removed enhancement Changes that are not breaking labels Feb 21, 2024
@Flo0807 Flo0807 marked this pull request as draft February 21, 2024 08:03
@Flo0807 Flo0807 force-pushed the feature/improve-filter branch from 74590e2 to 6618fc0 Compare February 21, 2024 08:26
@Flo0807 Flo0807 marked this pull request as ready for review February 21, 2024 08:28
lib/backpex/filters/boolean.ex Outdated Show resolved Hide resolved
lib/backpex/filters/boolean.ex Outdated Show resolved Hide resolved
Base automatically changed from feature/pipeline to develop February 28, 2024 07:07
@Flo0807 Flo0807 merged commit 55e50d9 into develop Mar 20, 2024
11 checks passed
@Flo0807 Flo0807 deleted the feature/improve-filter branch March 20, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants