Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil value was not properly displayed in select field #122

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

Flo0807
Copy link
Collaborator

@Flo0807 Flo0807 commented Feb 21, 2024

We used Atom.to_string before searching for a label in Backpex.Fields.Select. If the value was nil this caused the value to become "nil". When we could not find an option with label "nil" we returned the value itself, so "nil" was displayed on show views.

@Flo0807 Flo0807 added the bug Something isn't working label Feb 21, 2024
@Flo0807 Flo0807 merged commit 4ac1a6e into develop Feb 21, 2024
1 check passed
@Flo0807 Flo0807 deleted the feature/fix-nil-select branch February 21, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant