Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename item and resource action init_change/1 callback to base_schema/1 #672

Merged
merged 11 commits into from
Nov 27, 2024

Conversation

Flo0807
Copy link
Collaborator

@Flo0807 Flo0807 commented Nov 26, 2024

The term init_change is confusing because the result is used as the base schema / item for the changeset function.

@Flo0807 Flo0807 self-assigned this Nov 26, 2024
@Flo0807 Flo0807 added the breaking-change A breaking change label Nov 26, 2024
@Flo0807 Flo0807 changed the title Rename item action init_change callback to ? Rename item action init_change callback to base_item Nov 26, 2024
@Flo0807 Flo0807 changed the title Rename item action init_change callback to base_item Rename item / resource action init_change callback to base_item Nov 26, 2024
@Flo0807 Flo0807 changed the title Rename item / resource action init_change callback to base_item Rename item and resource action init_change callback to base_item Nov 26, 2024
@Flo0807 Flo0807 changed the title Rename item and resource action init_change callback to base_item Rename item and resource action init_change/1 callback to base_item/1 Nov 26, 2024
@Flo0807 Flo0807 changed the title Rename item and resource action init_change/1 callback to base_item/1 Rename item and resource action init_change/1 callback to base_schema/1 Nov 27, 2024
@Flo0807 Flo0807 requested a review from pehbehbeh November 27, 2024 08:13
@pehbehbeh pehbehbeh merged commit a058995 into develop Nov 27, 2024
6 checks passed
@pehbehbeh pehbehbeh deleted the feature/rename-item-action-init-change-callback branch November 27, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants