-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitcoin bounty #2
Open
d80ep08th
wants to merge
21
commits into
nblockchain:master
Choose a base branch
from
d80ep08th:gitcoin-bounty
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did this using x:Name = "" in the tags I wanted to manipulate
Changing the amount value will dynamically change lengths of the 4 arcs according to the percentages in render(amount)
@d80ep08th good work so far! This is not finished yet, though, because I've found a little problem with it, but bear with me, I'm sure you will be able to resolve it very easily. I'll comment on the diff. |
knocte
reviewed
May 16, 2022
The new normalize function ranks the values first , saves the ranks in a list at the same positions of the crypto amount value and then creates pies from the ranks list. Also. new variable `gap` to manipulate gap between arcs
Makes a circle when a single value is passed
Smallest gap that can be maintained between two arcs
e.g. 99&1 being converted to 98&2, but 99.1&0.9 being converted to 100&0
This reverts commit 5ddf466.
Blackbarbie8
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should close Issue #1