commitlint,FileConventions: partial fix for #120 #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make the code more understandable. Also: a micro- optimization, as there's no need to get nextLine if code doesn't get inside the next block.
knocte
force-pushed
the
wip/fixBugsReportedInCommitMsg
branch
3 times, most recently
from
f7cc0ce to
20b939b
Compare
knocte
force-pushed
the
wip/fixBugsReportedInCommitMsg
branch
from
20b939b to
9337018
Compare
The testcase comes from: #120 (comment)
knocte
force-pushed
the
wip/fixBugsReportedInCommitMsg
branch
2 times, most recently
from
9ef1128 to
8829c99
Compare
|
@aarani please review |
knocte
force-pushed
the
wip/fixBugsReportedInCommitMsg
branch
3 times, most recently
from
3fd01ea to
cd7c62e
Compare
Partial fix for: #120 Co-authored-by: webwarrior <[email protected]>
knocte
force-pushed
the
wip/fixBugsReportedInCommitMsg
branch
from
9811390 to
6cb6d10
Compare
knocte
changed the title
knocte
added a commit
that referenced
this pull request
Jul 19, 2023
FileConventions,commitlint: partial fix for #120.
knocte
added a commit
that referenced
this pull request
Jul 19, 2023
FileConventions,commitlint: partial fix for [1]. [1] #120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.