FIX unit tests & add a null-check before getting the array length of …

…new property filesRemovedList
ndelangen · Jul 9, 2019 · 3a450de · 3a450de
1 parent b680151
commit 3a450de
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/packages/jest-reporters/src/__tests__/get_snapshot_summary.test.js b/packages/jest-reporters/src/__tests__/get_snapshot_summary.test.js
@@ -21,6 +21,7 @@ test('creates a snapshot summary', () => {
     didUpdate: false,
     filesAdded: 1,
     filesRemoved: 1,
+    filesRemovedList: [],
     filesUnmatched: 1,
     filesUpdated: 1,
     matched: 2,
@@ -49,6 +50,7 @@ test('creates a snapshot summary after an update', () => {
     didUpdate: true,
     filesAdded: 1,
     filesRemoved: 1,
+    filesRemovedList: [],
     filesUnmatched: 1,
     filesUpdated: 1,
     unchecked: 1,
@@ -75,6 +77,7 @@ it('creates a snapshot summary with multiple snapshot being written/updated', ()
     didUpdate: false,
     filesAdded: 2,
     filesRemoved: 2,
+    filesRemovedList: [],
     filesUnmatched: 2,
     filesUpdated: 2,
     unchecked: 2,
@@ -105,6 +108,7 @@ it('returns nothing if there are no updates', () => {
     didUpdate: false,
     filesAdded: 0,
     filesRemoved: 0,
+    filesRemovedList: [],
     filesUnmatched: 0,
     filesUpdated: 0,
     unchecked: 0,

diff --git a/packages/jest-reporters/src/__tests__/summary_reporter.test.js b/packages/jest-reporters/src/__tests__/summary_reporter.test.js
@@ -70,6 +70,7 @@ test('snapshots needs update with yarn test', () => {
     numTotalTestSuites: 1,
     numTotalTests: 1,
     snapshot: {
+      filesRemovedList: [],
       filesUnmatched: 1,
       total: 2,
       uncheckedKeysByFile: [],
@@ -98,6 +99,7 @@ test('snapshots all have results (no update)', () => {
       didUpdate: false,
       filesAdded: 1,
       filesRemoved: 1,
+      filesRemovedList: [],
       filesUnmatched: 1,
       filesUpdated: 1,
       matched: 2,
@@ -134,6 +136,7 @@ test('snapshots all have results (after update)', () => {
       didUpdate: true,
       filesAdded: 1,
       filesRemoved: 1,
+      filesRemovedList: [],
       filesUnmatched: 1,
       filesUpdated: 1,
       matched: 2,

diff --git a/packages/jest-reporters/src/get_snapshot_summary.ts b/packages/jest-reporters/src/get_snapshot_summary.ts
@@ -84,7 +84,7 @@ export default (
       );
     }
   }
-  if (snapshots.filesRemovedList.length) {
+  if (snapshots.filesRemovedList && snapshots.filesRemovedList.length) {
     const [head, ...tail] = snapshots.filesRemovedList;
     summary.push(`  ${DOWN_ARROW} ${DOT}${formatTestPath(globalConfig, head)}`);