Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wobbliness/tearing #9

Open
9ary opened this issue Oct 8, 2019 · 6 comments
Open

Wobbliness/tearing #9

9ary opened this issue Oct 8, 2019 · 6 comments

Comments

@9ary
Copy link
Member

9ary commented Oct 8, 2019

The guides and selection appear to redraw much faster than vsync which leads to wobbly diagonal lines in pieces.

@expectocode
Copy link
Member

how do we fix this

@9ary
Copy link
Member Author

9ary commented Dec 5, 2019

@expectocode by losing the game

expectocode pushed a commit that referenced this issue Mar 26, 2020
@pickfire
Copy link
Contributor

@9ary Isn't it because we are reallocating memory every time?

@9ary
Copy link
Member Author

9ary commented Mar 30, 2020

No, it's because we're redrawing way too fast.

@pickfire
Copy link
Contributor

@9ary should we limit the redraw rate to 60 fps?

@9ary
Copy link
Member Author

9ary commented Mar 30, 2020

It's not that simple, we need to do vsync somehow but that's not exactly easy with xshape. The alternative is drawing with opengl or xrender, where it's easy to do vsync, but that requires a compositor. slop dumbly throttles drawing like you suggest which reduces tearing but doesn't entirely remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants