This repository has been archived by the owner on Mar 26, 2021. It is now read-only.
Travis ci #18
Merged
Travis ci #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewilz
force-pushed
the
travis_ci
branch
2 times, most recently
from
ed95e7c to
fc3ba7c
Compare
ewilz
commented
Jun 3, 2020
src/tests/mod.rs
Outdated
| @@ -135,7 +135,7 @@ fn test_contract_to_eoa_transfer() { | |||
| fn test_get_code() { | |||
| test_utils::run_test(0, |contract| { | |||
| let test_addr = contract.deploy_code(TEST.to_string()); | |||
| assert!(contract.get_code(test_addr).len() > 3000); | |||
| assert!(contract.get_code(test_addr).len() > 3001); // contract code should roughly be over length 3000 | |||
There was a problem hiding this comment.
toggled to test build, I can make it 3000 for official mergeable PR
There was a problem hiding this comment.
oh wait i don't have to do this anymore!! This was a docker thing 😂
ewilz
commented
Jun 3, 2020
| > build/subcontract.abi | ||
| > build/SubContract.abi | ||
|
|
||
| rm -rf build/contracts |
No it is not. We still want to leave in the build step so we can be sure we don't introduce changes that break the wasm build, but it can be paralellized |
ewilz
force-pushed
the
travis_ci
branch
11 times, most recently
from
3f92ad6 to
2bc0072
Compare
prestwich
approved these changes
Jun 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things going on here:
Took
src/tests/buildout of.gitignoreso the built contracts are included with repo. Setting up an entire node/truffle environment for test contracts that are very unlikely to change much seemed like a lot of overhead for situations with no node/truffle..travis.ymlsplit into 2 jobs. no node/truffle../build.shno longer fails silentlyUpdated rust-toolchain