refactor: move EpochManager functions as default impl for EpochManagerAdapter #12851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pugachAG
changed the title
possible_epochs_of_height_around_tip as default impl
pugachAG
force-pushed
the
inline-epochs-around-tip
branch
from
eb3e3ad to
ed9682e
Compare
Longarithm
approved these changes
Jan 31, 2025
stedfn
reviewed
Jan 31, 2025
| @@ -239,7 +253,7 @@ pub trait EpochManagerAdapter: Send + Sync { | |||
| /// it for "production" code. | |||
| fn get_validator_info( | |||
| &self, | |||
| epoch_id: ValidatorInfoIdentifier, | |||
| epoch_identifier: ValidatorInfoIdentifier, | |||
There was a problem hiding this comment.
epoch_id usually corresponds to a variable of type EpochId in this file, so renaming to avoid confusing
stedfn
approved these changes
Jan 31, 2025
pugachAG
force-pushed
the
inline-epochs-around-tip
branch
5 times, most recently
from
a0c0f69 to
a8e0051
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12851 +/- ##
==========================================
- Coverage 70.39% 70.38% -0.01%
==========================================
Files 853 853
Lines 174093 174006 -87
Branches 174093 174006 -87
==========================================
- Hits 122548 122473 -75
+ Misses 46324 46317 -7
+ Partials 5221 5216 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pugachAG
force-pushed
the
inline-epochs-around-tip
branch
from
a8e0051 to
279d62b
Compare
|
@Longarithm just FYU I've pushed quite a few changes after your approval, so maybe you would like to take another look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves implementation for a bunch of functions from
EpochManagerto be the default implementation inEpochManagerAdaptertrait.Also
is_slashedis removed from the API since we do not properly support slashing.