Don't crash on "Connection reset by peer" #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1887 introduced `expect("Decoder error")` which was incorrect because Decoder error is not the only error case for FramedRead stream: error could come from the underlying tcp stream. The old behavior was to ignore the error, the behavior with this change is to print the error and stop the stream.
chain/network/src/peer_manager.rs
Outdated
| .take_while(|x| match x { | ||
| Ok(_) => future::ready(true), | ||
| Err(e) => { | ||
| error!(target: "network", "Peer stream error: {:?}", e); |
There was a problem hiding this comment.
If the peer stream closes I don't think there is a need to log in error!
There was a problem hiding this comment.
We should at least log in warn since this is not expected behavior. I agree that this is not an error in this node, but about node in the other side.
Codecov Report
@@ Coverage Diff @@
## staging #1954 +/- ##
===========================================
+ Coverage 86.61% 86.66% +0.05%
===========================================
Files 167 167
Lines 31488 31659 +171
===========================================
+ Hits 27273 27437 +164
- Misses 4215 4222 +7
Continue to review full report at Codecov.
|
mfornet
approved these changes
Jan 14, 2020
SkidanovAlex
approved these changes
Jan 14, 2020
ailisp
approved these changes
Jan 15, 2020
SkidanovAlex
added a commit
that referenced
this pull request
Jan 29, 2020
* Don't crash on "Connection reset by peer" #1887 introduced `expect("Decoder error")` which was incorrect because Decoder error is not the only error case for FramedRead stream: error could come from the underlying tcp stream. The old behavior was to ignore the error, the behavior with this change is to print the error and stop the stream. * warn instead of error Co-authored-by: Alexander Skidanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1887 introduced
expect("Decoder error")which was incorrect because Decoder error isnot the only error case for FramedRead stream: error could come from the
underlying tcp stream.
The old behavior was to ignore the error, the behavior with this change
is to print the error and stop the stream.