Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Promise in vm-logic. Remove inner type #1978

Merged
merged 4 commits into from
Jan 21, 2020

Conversation

evgenykuzyakov
Copy link
Collaborator

Simplifying Promise type within VMLogic.

@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #1978 into staging will decrease coverage by 0.3%.
The diff coverage is 55.45%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #1978      +/-   ##
===========================================
- Coverage    87.49%   87.19%   -0.31%     
===========================================
  Files          167      167              
  Lines        31779    31944     +165     
===========================================
+ Hits         27804    27852      +48     
- Misses        3975     4092     +117
Impacted Files Coverage Δ
core/primitives/src/views.rs 59.83% <ø> (ø) ⬆️
chain/client/src/lib.rs 0% <ø> (ø) ⬆️
chain/client/src/types.rs 80.46% <ø> (-1.57%) ⬇️
chain/chain/src/types.rs 97.97% <ø> (ø) ⬆️
chain/jsonrpc/client/src/lib.rs 83.58% <ø> (ø) ⬆️
core/store/src/db.rs 79.85% <0%> (-7.86%) ⬇️
core/store/src/lib.rs 88.88% <0%> (-2.68%) ⬇️
chain/client/src/view_client.rs 70.52% <0%> (-0.99%) ⬇️
runtime/runtime/src/state_viewer.rs 92.61% <100%> (+0.04%) ⬆️
runtime/runtime/src/lib.rs 82.34% <100%> (+0.16%) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f62fff9...ae4fac2. Read the comment docs.

@nearprotocol-bulldozer nearprotocol-bulldozer bot merged commit 0db90f0 into staging Jan 21, 2020
@nearprotocol-bulldozer nearprotocol-bulldozer bot deleted the simplify-vm-logic-promise branch January 21, 2020 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants