Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check account id inside tx status query #2023

Merged
merged 3 commits into from
Jan 28, 2020

Conversation

bowenwang1996
Copy link
Collaborator

Do not allow invalid account ids when we process transaction status queries.

@codecov
Copy link

codecov bot commented Jan 26, 2020

Codecov Report

Merging #2023 into staging will decrease coverage by 0.37%.
The diff coverage is 43.52%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #2023      +/-   ##
===========================================
- Coverage    87.41%   87.04%   -0.38%     
===========================================
  Files          169      170       +1     
  Lines        33384    33424      +40     
===========================================
- Hits         29182    29093      -89     
- Misses        4202     4331     +129
Impacted Files Coverage Δ
runtime/near-vm-logic/src/gas_counter.rs 94.44% <ø> (ø) ⬆️
...ime/near-vm-runner/tests/test_invalid_contracts.rs 83.33% <ø> (ø) ⬆️
near/tests/stake_nodes.rs 97.41% <ø> (-0.01%) ⬇️
runtime/near-vm-logic/tests/helpers.rs 97.82% <ø> (ø) ⬆️
runtime/runtime/src/lib.rs 85.38% <ø> (ø) ⬆️
runtime/near-vm-runner/src/imports.rs 100% <ø> (ø) ⬆️
chain/network/src/types.rs 74.55% <ø> (-0.41%) ⬇️
runtime/near-vm-logic/src/types.rs 33.33% <ø> (ø) ⬆️
core/primitives/src/test_utils.rs 93.16% <0%> (-6.84%) ⬇️
chain/network/tests/stress_network.rs 0% <0%> (ø)
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6467ca...f55b20a. Read the comment docs.

@bowenwang1996 bowenwang1996 merged commit 3b2a004 into staging Jan 28, 2020
@bowenwang1996 bowenwang1996 deleted the check-account-id-tx-status branch January 28, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants