Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuffle incoming receipts for each shard #2032

Merged
merged 2 commits into from
Feb 3, 2020
Merged

Conversation

bowenwang1996
Copy link
Collaborator

Fix #2028

@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #2032 into staging will increase coverage by 0.17%.
The diff coverage is 91.43%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #2032      +/-   ##
===========================================
+ Coverage    86.97%   87.14%   +0.17%     
===========================================
  Files          170      169       -1     
  Lines        33502    33946     +444     
===========================================
+ Hits         29139    29583     +444     
  Misses        4363     4363
Impacted Files Coverage Δ
chain/network/tests/runner/mod.rs 96.14% <ø> (ø) ⬆️
chain/chain/src/lib.rs 100% <ø> (ø) ⬆️
near/src/config.rs 95.2% <ø> (-0.02%) ⬇️
chain/client/tests/bug_repros.rs 92.68% <ø> (ø) ⬆️
chain/jsonrpc/tests/rpc_query.rs 98.18% <ø> (-0.04%) ⬇️
chain/network/src/test_utils.rs 91.75% <ø> (-0.09%) ⬇️
chain/chain/src/error.rs 75.92% <ø> (ø) ⬆️
near/src/lib.rs 98.21% <ø> (ø) ⬆️
chain/network/tests/stress_network.rs 0% <0%> (ø) ⬆️
core/primitives/src/test_utils.rs 92.59% <100%> (-0.57%) ⬇️
... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b154727...4985f71. Read the comment docs.

Copy link
Collaborator

@evgenykuzyakov evgenykuzyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some integration test would be cool

@bowenwang1996 bowenwang1996 merged commit 5c801a9 into staging Feb 3, 2020
@bowenwang1996 bowenwang1996 deleted the fix-shard-equality branch February 3, 2020 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants