Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keccak native support #2045

Merged
merged 10 commits into from
Feb 5, 2020

Conversation

k06a
Copy link
Contributor

@k06a k06a commented Jan 30, 2020

Related to: near/near-sdk-rs#69

@k06a k06a force-pushed the feature/keccak-native-support branch from e55928c to b824fc9 Compare January 31, 2020 19:58
@evgenykuzyakov
Copy link
Collaborator

Seems you need to run cargo rust fmt.

runtime/near-vm-logic/src/logic.rs Outdated Show resolved Hide resolved
runtime/near-vm-logic/src/logic.rs Outdated Show resolved Hide resolved
@evgenykuzyakov
Copy link
Collaborator

Please also update nomicon https://nomicon.io/Runtime/Components/BindingsSpec/MathAPI.html

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

❗ No coverage uploaded for pull request base (staging@ba54888). Click here to learn what that means.
The diff coverage is 97.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             staging    #2045   +/-   ##
==========================================
  Coverage           ?   87.05%           
==========================================
  Files              ?      170           
  Lines              ?    33909           
  Branches           ?        0           
==========================================
  Hits               ?    29520           
  Misses             ?     4389           
  Partials           ?        0
Impacted Files Coverage Δ
near/tests/stake_nodes.rs 97.36% <ø> (ø)
near/src/config.rs 95.2% <ø> (ø)
chain/client/tests/challenges.rs 95.61% <100%> (ø)
chain/client/tests/chunks_management.rs 96.99% <100%> (ø)
chain/client/src/client.rs 94.37% <100%> (ø)
chain/client/tests/process_blocks.rs 79.15% <100%> (ø)
chain/chain/src/doomslug.rs 98.56% <100%> (ø)
chain/client/src/test_utils.rs 76.6% <100%> (ø)
chain/client/src/client_actor.rs 85.87% <71.42%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba54888...6614390. Read the comment docs.

@evgenykuzyakov
Copy link
Collaborator

@k06a I got an error when trying to launch local testnet with this branch:

Starting NEAR client...
Autoupdate is not supported at the moment for runs outside of docker
thread 'main' panicked at 'Failed to deserialize the genesis config.: Error("missing field `keccak256_base`", line: 173, column: 7)', src/libcore/result.rs:1165:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

Not sure why it's needed in genesis. I thought we should be just using defaults. Something went wrong I guess

@k06a
Copy link
Contributor Author

k06a commented Feb 5, 2020

@evgenykuzyakov try to erase ./testdir in repo

Copy link
Contributor

@MaksymZavershynskyi MaksymZavershynskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Published to crates.io. @k06a you can start using it in near-bindgen . It will automerge once CI completes.

@nearprotocol-bulldozer nearprotocol-bulldozer bot merged commit 05a82d8 into staging Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants