Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract metadata #38

Closed
wants to merge 22 commits into from
Closed

Conversation

bowenwang1996
Copy link

Basic implementation of contract metadata described here.

dcodeIO and others added 21 commits June 12, 2019 18:38
…pt#672

Previously realloc falsely copied the RC of the old block and missed to inform rtrace of the implicit free
@DanielRX
Copy link

Main thing I noticed that would keep the format, but reduce code size
The current JSON is

viewMethods: {
    [methodName: string]: {
        name: string (methodName),
        parameters: {[key: string]: string},
        returnType: string
    }
}

by removing name: methodName, or converting viewMethods into an array, you reduce the size of the JSON by the total string length of all method names, and the name being duplicated doesn't serve any benefit to the developer

@vgrichina
Copy link

I agree that we don't really need name: string (methodName), part

@bowenwang1996
Copy link
Author

Yeah I'll change that

@willemneal willemneal force-pushed the assemblyscript-update branch from bb8e894 to 2717134 Compare August 2, 2019 19:39
@bowenwang1996 bowenwang1996 deleted the contract-metadata branch September 20, 2019 01:24
@bowenwang1996 bowenwang1996 restored the contract-metadata branch September 20, 2019 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants