Add deploy command #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will use Capfile files in your Pulsar conf repo and generate a proper Capfile so that Cap 3 can be run.
These interactors will bundle install and run capistrano
Closed
Running in a separate process it's difficult to stub system Ruby methods (that run Capistrano). This is a workaround but should make the specs easier.
kennyadsl
approved these changes
Mar 14, 2017
| context.bundle_path = "#{PULSAR_HOME}/bundle" | ||
| context.run_path = "#{PULSAR_TMP}/run-#{context.timestamp}" | ||
| context.config_path = "#{context.run_path}/conf" | ||
| context.cap_path = "#{context.run_path}/cap" |
There was a problem hiding this comment.
maybe we can align these variables assignments as we did in other files?
spec/units/organizers/deploy_spec.rb
Outdated
| Pulsar::IdentifyRepositoryLocation, Pulsar::IdentifyRepositoryType, | ||
| Pulsar::CreateRunDirs, Pulsar::CloneRepository, Pulsar::CreateCapfile, | ||
| Pulsar::CreateDeployFile, Pulsar::CopyEnvironmentFile, | ||
| Pulsar::RunBundleInstall, Pulsar::RunCapistrano, Pulsar::Cleanup |
There was a problem hiding this comment.
I'd personally use one line for each command, just for increase readability
spec/units/organizers/list_spec.rb
Outdated
| @@ -11,7 +11,8 @@ | |||
| let(:interactors) do | |||
| [ | |||
| Pulsar::IdentifyRepositoryLocation, Pulsar::IdentifyRepositoryType, | |||
| Pulsar::CloneRepository, Pulsar::AddApplications, Pulsar::Cleanup | |||
| Pulsar::CreateRunDirs, Pulsar::CloneRepository, Pulsar::AddApplications, | |||
| Pulsar::Cleanup | |||
mtylty
force-pushed
the
add-deploy-command
branch
from
434b3f8
to
323d591
Compare
mtylty
force-pushed
the
add-deploy-command
branch
3 times, most recently
from
ec6732d
to
067e0a2
Compare
mtylty
force-pushed
the
add-deploy-command
branch
2 times, most recently
from
107b27e
to
94f090f
Compare
|
There's a nasty bug on the CI: rubygems/bundler#4602 It's running locally so I'm going to merge this. We'll think about it later 🙈 🙉 🙊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally adds a rudimentary deploy command that creates a Capistrano 3 folder structure based on Pulsar configurations.
Specs are a little strange and incomplete because I still need to find a way to stub calls to the
capcommand.The pulsar-conf repo is changed as well, the updated structure is on nebulab/pulsar-conf-demo.
A README is also missing but we'll do that on a separate PR.