Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving Solidus event subscribers autoload PR #45

Closed
spaghetticode opened this issue May 25, 2020 · 1 comment
Closed

Improving Solidus event subscribers autoload PR #45

spaghetticode opened this issue May 25, 2020 · 1 comment
Assignees
@spaghetticode

Comments

@spaghetticode
Copy link
Member

spaghetticode commented May 25, 2020 •
edited
Loading

This PR still needs some work. The core team also decided that we need to backport the functionality to extensions as well with a similar PR on solidus_support. In the meantime, I was able to confirm that there are no reload issues related to this new functionality and that the change in solidus_support is feasible and will work properly.
@spaghetticode spaghetticode self-assigned this May 29, 2020
@spaghetticode spaghetticode changed the title Improving https://github.com/solidusio/solidus/pull/3571 Improving Solidus event subscribers autoload PR May 29, 2020
@spaghetticode
Copy link
Member Author

The PR is ready. I also opened the corresponding PR for Solidus extensions. A demo app helps in verifying that everything integrates and works as expected.

@elia elia closed this as completed Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spaghetticode spaghetticode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elia @spaghetticode