Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoload Solidus Event subscribers from extensions #45

Merged

Conversation

spaghetticode
Copy link
Member

Just like it happens for Solidus core event subscribers and subscribers added by app developers, this change allows to automatically load and subscribe event subscriber files that are located inside Solidus extensions.

See solidusio/solidus#3571 for further details.

Also, I created a demo app that shows the new feature at work and can be easily used to verify that code reload works as expected with autoloaded event subscribers.

Just like it happens for Solidus core event subscribers and subscribers
added by app developers, this allows to automatically load and subscribe
event subscriber files that are located inside Solidus extensions.
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@aldesantis aldesantis merged commit c7ce0e2 into solidusio:master Jun 2, 2020
@aldesantis aldesantis deleted the spaghetticode/autoload-subscribers branch June 2, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants