[ImageLoader] Call failure callback from getSize when image decoding …

…fails
necolas · Jan 14, 2025 · f8ddd30 · f8ddd30
1 parent a46e085
commit f8ddd30
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/packages/react-native-web/src/modules/ImageLoader/__tests__/index-test.js b/packages/react-native-web/src/modules/ImageLoader/__tests__/index-test.js
@@ -35,6 +35,16 @@ describe('ImageLoader', () => {
     expect(failureCallback).toHaveBeenCalledTimes(1);
     expect(successCallback).toHaveBeenCalledTimes(0);
   });
+
+  test('Failure callback is called when image fails to decode', async () => {
+    window.Image = NotDecodingMockImage;
+    const successCallback = jest.fn();
+    const failureCallback = jest.fn();
+    ImageLoader.getSize(testImage, successCallback, failureCallback);
+    await jest.runAllTimers();
+    expect(failureCallback).toHaveBeenCalledTimes(1);
+    expect(successCallback).toHaveBeenCalledTimes(0);
+  });
 });
 
 class MockImage {
@@ -67,3 +77,9 @@ class NotLoadingMockImage extends MockImage {
     window.setTimeout(this.onerror, 0);
   }
 }
+
+class NotDecodingMockImage extends MockImage {
+  decode() {
+    return Promise.reject();
+  }
+}
diff --git a/packages/react-native-web/src/modules/ImageLoader/index.js b/packages/react-native-web/src/modules/ImageLoader/index.js
@@ -95,6 +95,8 @@ const ImageLoader = {
         const { naturalHeight, naturalWidth } = image;
         if (naturalHeight && naturalWidth) {
           success(naturalWidth, naturalHeight);
+        } else {
+          errorCallback();
         }
       }
     }