Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: VirtualizedList passive event listener warning #2601

Closed
wants to merge 4 commits into from
Closed

Fix: VirtualizedList passive event listener warning #2601

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40a0bba
[Fix] VirtualizedList passive event listener warning
tienifr Oct 25, 2023
e196d51
Merge branch 'master' of https://github.com/tienifr/react-native-web …
tienifr Apr 2, 2024
7a3702f
Remove redundant feature detection
tienifr Apr 2, 2024
8caedca
Revert redudant changes
tienifr Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native-web/src/modules/addEventListener/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export type EventOptions = {

const emptyFunction = () => {};

function supportsPassiveEvents(): boolean {
export function supportsPassiveEvents(): boolean {
let supported = false;
// Check if browser supports event with passive listeners
// https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#Safely_detecting_option_support
Expand Down
5 changes: 4 additions & 1 deletion packages/react-native-web/src/vendor/react-native/VirtualizedList/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,14 @@ import {
import invariant from 'fbjs/lib/invariant';
import nullthrows from 'nullthrows';
import * as React from 'react';
import { supportsPassiveEvents } from '../../../modules/addEventListener';

export type {RenderItemProps, RenderItemType, Separators};

const __DEV__ = process.env.NODE_ENV !== 'production';

const ON_EDGE_REACHED_EPSILON = 0.001;
const canUsePassiveEvents = supportsPassiveEvents();

let _usedIndexForKey = false;
let _keylessItemComponentName: string = '';
Expand Down Expand Up @@ -746,7 +748,8 @@ class VirtualizedList extends StateSafePureComponent<Props, State> {
setupWebWheelHandler() {
if (this._scrollRef && this._scrollRef.getScrollableNode) {
this._scrollRef.getScrollableNode().addEventListener('wheel',
this.invertedWheelEventHandler
this.invertedWheelEventHandler,
canUsePassiveEvents ? { passive: true } : false
tienifr marked this conversation as resolved.
Show resolved Hide resolved
);
} else {
setTimeout(() => this.setupWebWheelHandler(), 50);
Expand Down