-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix full class names #215
Fix full class names #215
Conversation
Test Suite Failing |
Hmmm I'm not too sure I've had this before but re-running has always helped. This time it doesn't seem to be doing the same trick |
lcov.info no content generated. |
Submitted again and again, and finally passed. |
We definitely need to work out why it's being so inconsistent as this is frustrating. Perhaps it just needs a delay in the git hub action or something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tianyiw2013,
Sorry for the delay in getting back to you on this. Happy new year and thanks for you work to date. I have a few bits of feedback.
- Would it be possible to break up the
getFullyQualifiedType
method into more methods. - There should probably be a
getClassesFromUse
method or something similar which just works with an individual line. - Please could we also use camelCase instead of snake_case
If you do not understand please let me know I understand english isn't your first language.
Thank you for your feedback. Is this OK now? Test Suite failed again. -_- |
@tianyiw2013 yes this is looking much neater thank you. I will look at the test suite issue as this is not on you for whatever reason it's being inconsistent |
@tianyiw2013 I believe I have fixed the problem with the coverage tests and have updated your branch |
Change Summary:
use some\namespace\{ ClassA, ClassB, ... }
Support PSR-12 use statements #122use some\namespace\ClassA, some\namespace\ClassB, ...
Checks:
CHANGELOG.md
updated with relavent changes