Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url mustache render test #387

Merged

Conversation

TonyBrobston
Copy link
Contributor

Fixes #371

Description of changes

When I have a secret with a uri in it, it has problems. Here is what the log shows:

trigger_1 | 2020-10-27T10:16:49-05:00 [Trigger House East Cat/Dog detector] Error: Failed to call DeepStack at http://deepstack-ai:5000/: Error: Invalid URI "http:///&/v1/vision/detection"

I wrote a test that I think identifies the issue. However I may be wrong. Essentially http://127.0.0.1:5000/ becomes http://127.0.0.1:5000/ and that seems to be a problem. I'm not sure why this would be a problem.

On a side note, when my secret is a username or password it seems to work fine; also note my usernames and passwords do not have special characters in it.

Checklist

  • User-facing change description added to unreleased section of CHANGELOG.md

@TonyBrobston
Copy link
Contributor Author

Alright, sounds like {{}} is html encoded and {{{}}} is not; that appears to be the issue which is proven by a passing test.

@TonyBrobston TonyBrobston changed the base branch from main to issue371 October 27, 2020 19:26
@neilenns neilenns merged commit d4cb4ee into neilenns:issue371 Oct 29, 2020
neilenns pushed a commit that referenced this pull request Oct 31, 2020
neilenns pushed a commit that referenced this pull request Nov 6, 2020
* Allow secrets in settings (#383)

* Fix uri encoding (#385)

* Fix mustache render url test (#387)

* Allow secrets in settings (#383)

* Fix uri encoding (#385)

* Fix mustache render url test (#387)

* Update changelog with security patch

Co-authored-by: Tony Brobston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

triggerUri exposes plain text Blue Iris Username and Password
2 participants