Adopt Black and check conformance in downstream repos #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drasmuss
reviewed
Jul 24, 2019
|
Pushed some commits to address Dan's review comments. |
drasmuss
reviewed
Jul 25, 2019
drasmuss
reviewed
Jul 25, 2019
tbekolay
commented
Jul 25, 2019
drasmuss
force-pushed
the
black
branch
3 times, most recently
from
2179031 to
eb0afff
Compare
drasmuss
approved these changes
Jul 26, 2019
tbekolay
commented
Jul 26, 2019
|
Fixups all look good to me! Only thing that'd be nice before merge is to add that changelog entry, which I'll leave to you @drasmuss. |
Check to ensure that files are black formatted in static checks. Add pre-commit-config.yaml to run Black as a precommit hook. Automatically run black on any Python template rendered by Bones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
Black automatically handles a lot of Python style decisions that we've spent time talking about in the past, freeing up our time for more important matters.
The only thing that I wasn't able to do in this PR is auto-format notebooks, though doing so is very close with black-nb. There are only a few minor issues with it, and rather than deal with them now, I chose to defer that to later. See #48 for details.
Interactions with other PRs:
Any other PR that touches Python code will have to be reformatted with Black. It shouldn't be very difficult though, as most of the changes in this PR are either straightforward or can be ignored and re-applied by running
blackagain.How has this been tested?
Ran the static tests locally with and without black formatted code to ensure that checks are raised correctly.
How long should this take to review?
Types of changes:
Checklist: