[feat]: More precise handling of errors when verifying connectivity #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
transistive
commented
Nov 29, 2024
transistive
commented
Nov 29, 2024
exaby73
force-pushed
the
feat/improved-connection-failure-handling
branch
from
43ca704 to
f24c5bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when we verify a connection, we catch any runtime exception.
This has led to confusing error handling, especially in more complex situations @exaby73 @AkshatSW.
When the connection can't be verified, we actually just want to check if we can reach the server. If any other error (e.g., Authentication errors) appears, we shouldn't handle it and let it bubble up so the end user is aware the connection is valid but some other client error happened.