run node-gyp from a local dependency #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 17, 2017 23:50
- Windows node - macOS node with nvm - macOS node with homebrew - macOS node with a vanilla install - Linux node In other words, all 5 of the 3 OSes node runs on. :P
… in Windows, eliminate the workaround hack for the rust issue that's been fixed.
|
@jedireza What do you think of bumping the Rust version requirement to the more recent 1.15, at least in Windows? With this PR I'm pretty sure it's required; with 1.13 it was hanging, I think because of rust-lang/rust#38811. |
|
I'm fine with bumping the minimum version of Rust to 1.15 for everything. It seems like a maintenance headache to require different versions of Rust for different environments. Changes look good. We should update the README with the minimum version for Rust though. |
r+
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.