Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust to 1.80.0 #8518

Merged
merged 7 commits into from
Jul 26, 2024
Merged

Update Rust to 1.80.0 #8518

merged 7 commits into from
Jul 26, 2024

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Jul 25, 2024

We keep the practice of keeping the compiler up to date, pointing to the latest release. This is done by many other projects in the Rust ecosystem as well.

Release notes.

Prior update was in #8048

We keep the practice of keeping the compiler up to date, pointing to the
latest release. This is done by many other projects in the Rust
ecosystem as well.

[Release notes](https://github.com/rust-lang/rust/releases/tag/1.80.0).

Prior update was in #8048
@arpad-m arpad-m added the run-extra-build-macos When placed on a PR, tells the CI to run a build on macOS. No unit tests are run, though. label Jul 25, 2024
@arpad-m arpad-m requested review from a team as code owners July 25, 2024 17:43
@arpad-m arpad-m requested review from conradludgate and jcsp July 25, 2024 17:43
Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update a Dockerfile for build-tools image?

ENV RUSTC_VERSION=1.79.0

@arpad-m arpad-m requested review from a team as code owners July 25, 2024 18:26
@arpad-m arpad-m requested a review from hlinnaka July 25, 2024 18:26
@arpad-m
Copy link
Member Author

arpad-m commented Jul 25, 2024

hmm legit error link:

#56 4.042 error[E0282]: type annotations needed for `Box<_>`
#56 4.042   --> /home/nonroot/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.23/src/format_description/parse/mod.rs:83:9
#56 4.042    |
#56 4.042 83 |     let items = format_items
#56 4.042    |         ^^^^^
#56 4.042 ...
#56 4.042 86 |     Ok(items.into())
#56 4.042    |              ---- type must be known at this point
#56 4.042    |
#56 4.042 help: consider giving `items` an explicit type, where the placeholders `_` are specified
#56 4.042    |
#56 4.042 83 |     let items: Box<_> = format_items
#56 4.042    |              ++++++++
#56 4.042 

according to this, it's a known breakage and it's recommended to update the time crate. The latest pg_jsonschema still doesn't have it yet, so I added a cargo update statement for the time crate.

edit: it seems to affect unrelated PRs as well, as we always take the latest stable rust release in that dockerfile:

https://github.com/neondatabase/neon/blob/main/Dockerfile.compute-node#L658-L659

Copy link

github-actions bot commented Jul 25, 2024

3132 tests run: 3011 passed, 0 failed, 121 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_cancellations: debug

Code coverage* (full report)

  • functions: 32.9% (7001 of 21299 functions)
  • lines: 50.1% (55769 of 111283 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
7184e55 at 2024-07-25T22:53:08.817Z :recycle:

@arpad-m arpad-m merged commit bb2a3f9 into main Jul 26, 2024
65 checks passed
@arpad-m arpad-m deleted the arpad/rust_1_80 branch July 26, 2024 09:17
@arpad-m arpad-m mentioned this pull request Sep 5, 2024
arpad-m added a commit that referenced this pull request Sep 6, 2024
We keep the practice of keeping the compiler up to date, pointing to the
latest release. This is done by many other projects in the Rust
ecosystem as well.

[Release notes](https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1810-2024-09-05).

Prior update was in #8667 and #8518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-extra-build-macos When placed on a PR, tells the CI to run a build on macOS. No unit tests are run, though.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants