Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update assets factory #180

Merged
merged 1 commit into from
Nov 10, 2023
Merged

refactor: update assets factory #180

merged 1 commit into from
Nov 10, 2023

Conversation

twlite
Copy link
Collaborator

@twlite twlite commented Nov 10, 2023

Description

Update assets factory to pull content from neplex' cdn.

Motivation and Context

Serving assets locally increases package size to over 5 megabytes.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@twlite twlite requested a review from notunderctrl November 10, 2023 13:28
@twlite twlite added the assets Assets related label Nov 10, 2023
notunderctrl
notunderctrl approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@notunderctrl notunderctrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@notunderctrl notunderctrl merged commit acfb5ea into main Nov 10, 2023
@notunderctrl notunderctrl deleted the refactor-assets branch November 10, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notunderctrl notunderctrl notunderctrl approved these changes

Assignees
No one assigned
Labels
assets Assets related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twlite @notunderctrl