Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix Docker container build #666

Merged
merged 7 commits into from
Jul 27, 2022
Merged

ci: fix Docker container build #666

merged 7 commits into from
Jul 27, 2022

Conversation

fhunleth
Copy link
Member

No description provided.

Copy link
Member

@jjcarstens jjcarstens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this isn't quite fixed?

@fhunleth
Copy link
Member Author

No, I pinged Digit for help.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@doawoo doawoo force-pushed the fix-docker-build branch 5 times, most recently from ded8e06 to 571f6bc Compare July 26, 2022 00:33
@doawoo doawoo force-pushed the fix-docker-build branch 5 times, most recently from 222e19c to 48eb69b Compare July 26, 2022 23:00
@doawoo
Copy link
Collaborator

doawoo commented Jul 27, 2022

OK! @fhunleth @jjcarstens I think I have finally figured out the dark arts of creating a multi-arch docker image. Turns out you cannot just push one easily outside of using --push in the buildx sub-command. So I build them individually, push them as dev tags, then combine them into a single manifest which will act like a "unified" AMD64/ARM64 image when pulled.

NOTE: we cannot test the ARM image easily in CircleCI, they do not support Docker ARM execution very well, and, it would simply take forever...

@fhunleth
Copy link
Member Author

@doawoo You're a hero! Thank you for figuring this out!!!!!

@fhunleth fhunleth merged commit 57e667c into main Jul 27, 2022
@fhunleth fhunleth deleted the fix-docker-build branch July 27, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants