Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gemspec #767

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

tagliala
Copy link
Collaborator

  • Relax dependencies to allow newer versions
  • Move development dependencies to Gemfile

This is a new best practice and will also avoid this warning:

A gemspec development dependency (riot, ~> 0.12.3) is being overridden by a Gemfile dependency (riot, >= 0).
This behaviour may change in the future. Please remove either of them, or make sure they both have the same requirement

Ref: https://docs.rubocop.org/rubocop/cops_gemspec.html#gemspecdevelopmentdependencies

- Relax dependencies to allow newer versions
- Move development dependencies to Gemfile

This is a new best practice and will also avoid this warning:

```
A gemspec development dependency (riot, ~> 0.12.3) is being overridden by a Gemfile dependency (riot, >= 0).
This behaviour may change in the future. Please remove either of them, or make sure they both have the same requirement
```

Ref: https://docs.rubocop.org/rubocop/cops_gemspec.html#gemspecdevelopmentdependencies
@tagliala tagliala marked this pull request as ready for review November 14, 2024 09:42
@tagliala tagliala merged commit da1efd8 into master Nov 14, 2024
14 checks passed
@tagliala tagliala deleted the chore/move-development-dependencies-to-gemfile branch November 14, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant