Merge pull request #13614 from dragontaek-lee/fix/middleware-builder-…

…exclude-overwrite fix(core): prevent exclude method from overwriting previous calls
nestjs · Jun 3, 2024 · de86355 · de86355
2 parents 2d5a7b8 + 4d88c79
commit de86355
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/integration/hello-world/e2e/exclude-middleware.spec.ts b/integration/hello-world/e2e/exclude-middleware.spec.ts
@@ -45,6 +45,11 @@ class TestController {
   overviewById() {
     return RETURN_VALUE;
   }
+
+  @Get('multiple/exclude')
+  multipleExclude() {
+    return RETURN_VALUE;
+  }
 }
 
 @Module({
@@ -59,6 +64,7 @@ class TestModule {
         path: 'middleware',
         method: RequestMethod.POST,
       })
+      .exclude('multiple/exclude')
       .forRoutes('*');
   }
 }
@@ -110,6 +116,12 @@ describe('Exclude middleware', () => {
       .expect(200, RETURN_VALUE);
   });
 
+  it(`should exclude "/multiple/exclude" endpoint`, () => {
+    return request(app.getHttpServer())
+      .get('/multiple/exclude')
+      .expect(200, RETURN_VALUE);
+  });
+
   afterEach(async () => {
     await app.close();
   });

diff --git a/packages/core/middleware/builder.ts b/packages/core/middleware/builder.ts
@@ -58,8 +58,9 @@ export class MiddlewareBuilder implements MiddlewareConsumer {
     public exclude(
       ...routes: Array<string | RouteInfo>
     ): MiddlewareConfigProxy {
-      this.excludedRoutes = this.getRoutesFlatList(routes).reduce(
-        (excludedRoutes, route) => {
+      this.excludedRoutes = [
+        ...this.excludedRoutes,
+        ...this.getRoutesFlatList(routes).reduce((excludedRoutes, route) => {
           for (const routePath of this.routeInfoPathExtractor.extractPathFrom(
             route,
           )) {
@@ -70,9 +71,8 @@ export class MiddlewareBuilder implements MiddlewareConsumer {
           }
 
           return excludedRoutes;
-        },
-        [] as RouteInfo[],
-      );
+        }, [] as RouteInfo[]),
+      ];
 
       return this;
     }