Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(microservices): Added invalid-grpc-message-decorator.exception.ts #12175

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

PhilipMantrov
Copy link
Contributor

@PhilipMantrov PhilipMantrov commented Aug 1, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

TypeError: Cannot read properties of undefined (reading 'value')

Issue Number: N/A

What is the new behavior?

InvalidGrpcDecoratorException[Error]: The invalid gRPC decorator (method "methodName" in service "serviceName")

Does this PR introduce a breaking change?

  • Yes
  • No

@coveralls
Copy link

Pull Request Test Coverage Report for Build a576ccfd-5015-47fa-9a69-79f0a6da3363

  • 9 of 11 (81.82%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 92.725%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/decorators/message-pattern.decorator.ts 7 8 87.5%
packages/microservices/errors/invalid-grpc-message-decorator.exception.ts 2 3 66.67%
Totals Coverage Status
Change from base Build 58e5c8f8-e60b-4fc4-aa73-86b16586db9a: -0.02%
Covered Lines: 6398
Relevant Lines: 6900

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

Could you provide us with a minimum reproduction repository/snippet?

@PhilipMantrov
Copy link
Contributor Author

PhilipMantrov commented Aug 15, 2023

example repo

without this fix (just yarn start)

var decorated = decorator(target);
                                ^
TypeError: Cannot read properties of undefined (reading 'value')

with this fix (after yarn cp_pr)

 var decorated = decorator(target);
                                ^
Error: The invalid gRPC decorator (method "testMethod" in service "TestService")

@PhilipMantrov
Copy link
Contributor Author

bump

@kamilmysliwiec kamilmysliwiec merged commit 704af4c into nestjs:master Dec 18, 2023
4 checks passed
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants