Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): support secureOptions on https options #13075

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented Jan 21, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: closes #13070

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build a3a699d4-6f13-42fe-b7ec-67d2749f274c

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.1%

Totals Coverage Status
Change from base Build 23b2c178-45c8-4170-aaae-666764ffa89e: 0.0%
Covered Lines: 6715
Relevant Lines: 7291

💛 - Coveralls

@micalevisk
Copy link
Member Author

micalevisk commented Jan 21, 2024

the failure doesn't seems to be related to the changes made here 🤔 Am I wrong?

image

@dammy001
Copy link
Contributor

the failure doesn't seems to be related to the changes made here 🤔 Am I wrong?

image

Flakky test i think

@kamilmysliwiec kamilmysliwiec merged commit 7595799 into nestjs:master Jan 23, 2024
4 of 5 checks passed
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpsOptions doesn't have SecureOptions
4 participants