chore(common): Add type declaration for RawBody decorator with pipes #14256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build f206fb07-9d65-44e5-aa8d-f3b37f665bb1Details
💛 - Coveralls |
| * | ||
| * @publicApi | ||
| */ | ||
| export function RawBody(): ParameterDecorator; |
There was a problem hiding this comment.
This is an overloaded method signature. Instead of removing it, we should just add one for the variant with pipes, right below this line
There was a problem hiding this comment.
The type declaration for RawBody(...args) already supports the empty parameter case RawBody(), so you can safely remove the separate empty parameter declaration.
the type declaration for RawBody(...args) already supports the empty parameter case RawBody(), so you can safely remove the separate empty parameter declaration.
There was a problem hiding this comment.
This is just for better DX - we do it all around the ecosystem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14254
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #14254
What is the new behavior?
The RawBody decorator now has proper TypeScript type declarations for pipe transformations. Users can now use pipes with the RawBody decorator with full type safety
Does this PR introduce a breaking change?
Other information