[client] Fix race condition while read/write conn status in peer conn #2607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pappz
changed the title
lixmal
approved these changes
Sep 17, 2024
|
|
||
| // AtomicConnStatus is a thread-safe wrapper for ConnStatus | ||
| type AtomicConnStatus struct { | ||
| status atomic.Int32 |
There was a problem hiding this comment.
I think we could remove the wrapper as it's only a single field, but that's a minor thing
There was a problem hiding this comment.
I did the wrapper because of the atom.Int32 stores Int32 and the ConnStatus is a custom type (because of the String method). So I tried to avoid the cast steps.
There was a problem hiding this comment.
I meant doing type AtomicConnStatus atomic.Int32 instead of the struct. But it's all right
mlsmaycon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The ConnStatus variable has been read in internal/peer/conn.go:330 and has been written in internal/peer/conn.go:422. It was not thread safe.
Issue ticket number and link
Checklist