Exit from processConnResults after all tries #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pappz
force-pushed
the
relay/fix/server-picker-stuck
branch
from
e86ea15
to
b8080e3
Compare
If all server is unavailable then the server picker never return because we never close the result channel. Count the number of the results and exit when we reached the expected size
pappz
force-pushed
the
relay/fix/server-picker-stuck
branch
from
b8080e3
to
10856d3
Compare
|
lixmal
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
If all server is unavailable then the server picker never returns because we never close the result channel
Issue ticket number and link
Checklist