Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] Check wginterface instead of engine ctx #2676

Merged

Conversation

hurricanehrndz
Copy link
Contributor

Describe your changes

Tweaking logic at connect to ensure wgInterface doesn't exist before starting a new engine #2196

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

Moving code to ensure wgInterface is gone right after context is
cancelled/stop in the off chance that on next retry the backoff
operation is permanently cancelled and interface is abandoned without
destroying.
@hurricanehrndz hurricanehrndz force-pushed the check_wginterface_instead_of_engine_ctx branch from 1d93790 to 96bb46e Compare September 30, 2024 17:11
Copy link

sonarcloud bot commented Oct 1, 2024

@mgarces
Copy link
Contributor

mgarces commented Oct 2, 2024

Did a build on linux amd64 docker, and it works perfectly; interface wt0 get's removed once docker process is stopped

@lixmal lixmal changed the title Check wginterface instead of engine ctx [client] Check wginterface instead of engine ctx Oct 4, 2024
@lixmal lixmal merged commit f603cd9 into netbirdio:main Oct 4, 2024
21 checks passed
@hurricanehrndz hurricanehrndz deleted the check_wginterface_instead_of_engine_ctx branch November 29, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants