Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[relay,client] Relay/fix/wg roaming #2691

Merged
merged 18 commits into from
Oct 11, 2024
Merged

[relay,client] Relay/fix/wg roaming #2691

merged 18 commits into from
Oct 11, 2024

Conversation

pappz
Copy link
Contributor

@pappz pappz commented Oct 3, 2024

Describe your changes

If a peer connection switches from Relayed to ICE P2P, the Relayed proxy still consumes the data the other peer sends. Because the proxy is operating, the WireGuard switches back to the Relayed proxy automatically, thanks to the roaming feature.

Extend the Proxy implementation with pause/resume functions. Before switching to the p2p connection, pause the WireGuard proxy operation to prevent unnecessary package sources.
Consider waiting some milliseconds after the pause to be sure the WireGuard engine already processed all UDP msg in from the pipe.

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@pappz pappz changed the title Relay/fix/wg roaming [relay,client] Relay/fix/wg roaming Oct 3, 2024
@pappz pappz marked this pull request as ready for review October 8, 2024 09:04
@mlsmaycon mlsmaycon requested a review from lixmal October 8, 2024 09:04
client/internal/peer/conn.go Outdated Show resolved Hide resolved
client/internal/wgproxy/ebpf/wrapper.go Show resolved Hide resolved
client/internal/wgproxy/ebpf/wrapper.go Outdated Show resolved Hide resolved
client/internal/wgproxy/ebpf/wrapper.go Show resolved Hide resolved
lixmal
lixmal previously approved these changes Oct 9, 2024
Copy link

sonarcloud bot commented Oct 9, 2024

@pappz pappz merged commit 0e95f16 into main Oct 11, 2024
21 checks passed
@pappz pappz deleted the relay/fix/wg-roaming branch October 11, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants