Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] Fix the broken dependency gvisor.dev/gvisor #2789

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

milantracy
Copy link
Contributor

Describe your changes

The gVisor release was removed which is described at
google/gvisor#11085 (comment).

Update the gVisor version in netbird to fix the build failure.

Issue ticket number and link

google/gvisor#11085

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2024

CLA assistant check
All committers have signed the CLA.

@paralin
Copy link

paralin commented Oct 26, 2024

Thank you for having a look at this. We are blocked by this adding a Buildroot package for netbird.

See: https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/#3402533

@milantracy
Copy link
Contributor Author

@pascal-fischer can you review the change?

Otherwise, could you assign some reviewers for the PR?

@lixmal
Copy link
Contributor

lixmal commented Oct 29, 2024

Hi @milantracy,

thanks for looking into a fix. Could you please go mod tidy?

The release was removed which is described at
google/gvisor#11085 (comment).
Copy link

sonarcloud bot commented Oct 29, 2024

@milantracy
Copy link
Contributor Author

Hi @milantracy,

thanks for looking into a fix. Could you please go mod tidy?

done.

@lixmal lixmal changed the title Fix the broken dependency gvisor.dev/gvisor. [client] Fix the broken dependency gvisor.dev/gvisor Oct 29, 2024
@lixmal lixmal merged commit a0cdb58 into netbirdio:main Oct 29, 2024
21 checks passed
hurricanehrndz added a commit to hurricanehrndz/netbird that referenced this pull request Nov 5, 2024
…te_change

* upstream/main: (81 commits)
  Fix cached device flow oauth (netbirdio#2833)
  Avoid failing all other matrix tests if one fails (netbirdio#2839)
  add all group to add peer affected peers network map check (netbirdio#2830)
  [client] Log windows panics (netbirdio#2829)
  Fix unused servers cleanup (netbirdio#2826)
  [management] Add DB access duration to logs for context cancel (netbirdio#2781)
  Allocate new buffer for every package (netbirdio#2823)
  [client] Nil check on ICE remote conn (netbirdio#2806)
  [management] remove network map diff calculations (netbirdio#2820)
  Create FUNDING.yml (netbirdio#2814)
  Create funding.json (netbirdio#2813)
  [management] add metrics to network map diff (netbirdio#2811)
  [client] Fix the broken dependency gvisor.dev/gvisor (netbirdio#2789)
  fix meta is equal slices (netbirdio#2807)
  [client] Fix multiple peer name filtering in netbird status command (netbirdio#2798)
  [management] Setup key improvements (netbirdio#2775)
  [client] allow relay leader on iOS (netbirdio#2795)
  [client] Remove legacy forwarding rules in userspace mode (netbirdio#2782)
  [client] Ignore route rules with no sources instead of erroring out (netbirdio#2786)
  [misc] Update Zitadel from v2.54.10 to v2.64.1
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants