Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[management] Enforce max conn of 1 for sqlite setups #2855

Merged
merged 2 commits into from
Nov 7, 2024
Merged

[management] Enforce max conn of 1 for sqlite setups #2855

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ade46a
enforce max conn of 1 for sqlite setups
pascal-fischer Nov 7, 2024
91430e0
fix log messages
pascal-fischer Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion management/server/sql_store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,17 @@ func NewSqlStore(ctx context.Context, db *gorm.DB, storeEngine StoreEngine, metr
if err != nil {
conns = runtime.NumCPU()
}

if storeEngine == SqliteStoreEngine {
if err == nil {
log.WithContext(ctx).Warnf("setting NB_SQL_MAX_OPEN_CONNS is not supported for sqlite, using default value 1")
}
conns = 1
}

sql.SetMaxOpenConns(conns)

log.Infof("Set max open db connections to %d", conns)
log.WithContext(ctx).Infof("Set max open db connections to %d", conns)

if err := migrate(ctx, db); err != nil {
return nil, fmt.Errorf("migrate: %w", err)
Expand Down
Loading