Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] Remove loop after route calculation #2856

Merged
merged 18 commits into from
Nov 11, 2024
Merged

Conversation

pappz
Copy link
Contributor

@pappz pappz commented Nov 7, 2024

Describe your changes

  • ICE do not trigger disconnect callbacks if the stated did not change
  • Fix route calculation callback loop
  • Move route state updates into protected scope by mutex
  • Do not calculate routes in case of peer.Open() and peer.Close()

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@pappz pappz marked this pull request as ready for review November 7, 2024 15:17
@pappz pappz changed the title Remove loop after route calculation [client] Remove loop after route calculation Nov 8, 2024
client/internal/routemanager/refcounter/refcounter.go Outdated Show resolved Hide resolved
client/internal/routemanager/client.go Outdated Show resolved Hide resolved
client/internal/peer/worker_ice.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 10, 2024

@pappz pappz merged commit b4d7605 into main Nov 11, 2024
21 checks passed
@pappz pappz deleted the limit-route-notification branch November 11, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants