Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow resolution of .local names with avahi-daemon in the apparmor profile #5088

Merged
merged 1 commit into from
Apr 17, 2022
Merged

Allow resolution of .local names with avahi-daemon in the apparmor profile #5088

merged 1 commit into from
Apr 17, 2022

Conversation

slowpeek
Copy link
Contributor

@slowpeek slowpeek commented Apr 2, 2022

Without this change here is what I see in syslog when running for example firejail --profile=ssh /usr/bin/ssh test.local:

Apr  2 14:59:29 kek kernel: [  177.596180] audit: type=1400 audit(1648900769.222:29): apparmor="DENIED" operation="connect" profile="firejail-default" name="/run/avahi-daemon/socket" pid=2562 comm="ssh" requested_mask="w" denied_mask="w" fsuid=1000 ouid=0

So it can't access the socket hence can't resolve the name.

@slowpeek
Update firejail-default
2d10e60 
Allow access to avahi-daemon socket in the apparmor profile.
glitsj16
glitsj16 approved these changes Apr 7, 2022
View reviewed changes
Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@netblue30 netblue30 merged commit ce0ca29 into netblue30:master Apr 17, 2022
@netblue30
Copy link
Owner

Merged! Thanks for the fix.

@kmk3 kmk3 added the enhancement New feature request label Apr 21, 2022
@kmk3 kmk3 changed the title Allow resolution of .local names with avahi-daemon in the apparmor profile. Allow resolution of .local names with avahi-daemon in the apparmor profile Jun 7, 2022
kmk3 added a commit that referenced this pull request Jun 8, 2022
@kmk3
RELNOTES: add feature/bugfix
35617a2 
Relates to #5088 #5114.
@rusty-snake rusty-snake mentioned this pull request Jun 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glitsj16 glitsj16 glitsj16 approved these changes

Assignees
No one assigned
Labels
enhancement New feature request
Projects
Release 0.9.70
Status: Done (on RELNOTES)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slowpeek @netblue30 @glitsj16 @kmk3