Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: note that blacklist/whitelist follow symlinks #5344

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

kmk3
Copy link
Collaborator

@kmk3 kmk3 commented Aug 29, 2022

Make it more explicit that they do and add an example for each command.

Relates to #5338.

Cc: @birdie-github @rusty-snake (from #5338)

kmk3 added 2 commits August 28, 2022 19:46
Format it and improve the grammar and explanation.
Make it more explicit that they do and add an example for each command.

Relates to netblue30#5338.
@kmk3 kmk3 added the documentation Issues and pull requests related to the documentation label Aug 29, 2022
@netblue30 netblue30 merged commit 57f35e5 into netblue30:master Aug 29, 2022
@netblue30
Copy link
Owner

all merged, thanks!

@kmk3 kmk3 deleted the docs-symlink-handling branch August 29, 2022 13:54
kmk3 added a commit that referenced this pull request Sep 6, 2022
As suggested by @birdie-github[1].

This amends commit c78c2b4 ("docs: note that blacklist/whitelist
follow symlinks", 2022-08-28) / PR #5344.

[1] #5344 (comment)
@kmk3
Copy link
Collaborator Author

kmk3 commented Sep 6, 2022

@birdie-github commented on Aug 29:

For example, if ~/foo is blacklisted and it points to /foo, then /foo will
also be blacklisted.

->

For example, if ~/foo is blacklisted and it points to /bar, then /bar will also be blacklisted.

Please fix.

Done on commit 160ccd3 ("docs: change /foo to /bar in symlink handling
example", 2022-08-29).

kmk3 added a commit to kmk3/firejail that referenced this pull request Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues and pull requests related to the documentation
Projects
Status: Done (on RELNOTES)
Development

Successfully merging this pull request may close these issues.

2 participants