Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles: gnome-logs: fix missing machine-id in private-etc #5651

Closed
wants to merge 1 commit into from

Conversation

glitsj16
Copy link
Collaborator

@glitsj16 glitsj16 commented Feb 8, 2023

Relates to #5610.

Side-note: although private-etc machine-id also fixes this, I opted to go with the 'new' groups syntax to avoid potential mishaps in future work on #5610 (e.g. etc-cleanup seeing machine-id again).

@SkewedZeppelin
Copy link
Collaborator

don't all programs with dbus need machine-id?

@glitsj16
Copy link
Collaborator Author

glitsj16 commented Feb 8, 2023

don't all programs with dbus need machine-id?

If you mean programs that use the D-Bus filtering, no not that I'm aware of. Good and interesting question though. My claws-mail blinked just before popping out for a walk, hence I noticed and read your question. Claws-mail would be broken too if all things using dbus-filtering would need access to /etc/machine-id. That's one app I can be pretty confident about. I'll have to check this more thoroughly to make sure my asumptions on this topic are indeed valid.

I did ran a few quick checks on apps I use daily and am familiar with. This shortlist all have dbus-user filter without machine-id in their private-etc option. And they all continue to work just fine: artha, claws-mail, evince, firefox, freetube (others I didn't re-check yet but I will do so later).

I find gnome-logs to be a bit of an odd-one-out. I straced it before and if memory serves it needs machine-id because systemd uses that for (checking) user access to the journal. The app wasn't entirely broken without machine-id in fact. But it does show a large red notification widget stating the current user doesn't have the proper privileges to read the logs (which is odd because my user is in the systemd-journal group). Yet it happily proceeds to show those nonetheless :) All in all not a comforting situation IMO, so I wanted to bring it in via this PR...

Always nice to see you around here, thanks for the hint!

@glitsj16 glitsj16 marked this pull request as draft February 13, 2023 01:41
@kmk3 kmk3 changed the title gnome-logs: fix private-etc, app needs machine-id profiles: gnome-logs: fix missing machine-id in private-etc Aug 25, 2024
The app can still read the logs without machine-id, but it does show a
large red notification widget stating that the current user doesn't have
the proper privileges to read the logs (even though the user is in the
systemd-journal group).

It was removed on commit 5d0822c ("private-etc: big profile changes",
2023-02-05).

Relates to netblue30#6400.
@kmk3
Copy link
Collaborator

kmk3 commented Aug 25, 2024

This was already added in:

@kmk3 kmk3 closed this Aug 25, 2024
@glitsj16 glitsj16 deleted the gnome-logs-fix branch August 25, 2024 16:44
@kmk3 kmk3 added the duplicate This issue or pull request already exists label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants