profiles: archiver-common: add mkinitcpio to private-etc #5656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glitsj16
changed the title
kmk3
reviewed
Feb 11, 2023
There was a problem hiding this comment.
Suggestion: Since this affects multiple archivers and considering that in #5655
you want to remove private-etc from the archivers (as it was added to
archivers-common.profile), add private-etc mkinitcpio* to
archivers-common.profile instead.
kmk3
changed the title
kmk3
pushed a commit
to glitsj16/firejail
that referenced
this pull request
Feb 11, 2023
Follow-up to netblue30#5656. Partly relates to netblue30#5610.
glitsj16
added a commit
to glitsj16/firejail
that referenced
this pull request
Feb 11, 2023
Moving it to archiver-comm.profile as suggested in [code review](netblue30#5656 (review)).
glitsj16
added a commit
to glitsj16/firejail
that referenced
this pull request
Feb 11, 2023
Moving it to archiver-comm.profile as suggested in [code review](netblue30#5656 (review)).
glitsj16
added a commit
to glitsj16/firejail
that referenced
this pull request
Feb 11, 2023
Moving it to archiver-comm.profile as suggested in [code review](netblue30#5656 (review)).
glitsj16
added a commit
to glitsj16/firejail
that referenced
this pull request
Feb 11, 2023
As suggested in [code review](netblue30#5656 (review)).
|
@kmk3 Thanks for the suggestion. Done! |
kmk3
changed the title
glitsj16
added a commit
to glitsj16/firejail
that referenced
this pull request
Mar 1, 2023
Follow-up to netblue30#5656. Partly relates to netblue30#5610.
glitsj16
added a commit
to glitsj16/firejail
that referenced
this pull request
Mar 3, 2023
Follow-up to netblue30#5656. Partly relates to netblue30#5610.
mkinitcpio (used to generate initramfs images) supports several compression formats: https://gitlab.archlinux.org/archlinux/mkinitcpio/mkinitcpio/-/blob/master/mkinitcpio.conf#L54-L64. On Arch Linux (based distributions) at least this implies the supported archivers to have access to mkinitcpio-related files under /etc. This was no problem before 29da82d added `private-etc` to `archivers-common.profile`. This adds the now needed extra private-etc items to archiver-common.profile, for mkinitcpio's supported compressors (which seem to be at least cpio, gzip and zstd). Relates to netblue30#5610.
kmk3
approved these changes
Mar 5, 2024
kmk3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mkinitcpio (used to generate initramfs images) supports several compression formats. On Arch Linux (based distributions) at least this implies the supported archivers to have access to mkinitcpio-related files under /etc.
This was no problem before 29da82d added
private-etctoarchivers-common.profile. This PR adds the now needed extra private-etc items to mkinitcpio's supported compressors.Relates to #5610.
Side-note: mkinitcpio also supports
lz4compression. I was a bit surprised to notice we don't have a profile for that yet. I'll add one in a follow-up PR.