-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiles: softmaker-common: add fstab to private-etc #5777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(There are a few suggestions but I can't review at the moment; leaving this as
a placeholder)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Sorry for the delay)
Change the commit message to something like the following:
softmaker-common.profile: add fstab to private-etc
When using `private-etc`, SoftMaker Office "forgets" that it was activated
already & asks for product key again.
Allowing access to "/etc/fstab" fixes the following error:
The application cannot create a unique identifier.
Please make sure the application has sufficient permissions.
Fixes #5773.
Main changes:
- Clarify in the title what the commit does
- Indent error message by 4 spaces
- Add "Fixes #XXX", which makes the issue be closed automatically when the PR
is merged
See the following for details:
Amending the commit message can be done with:
# (change the commit locally)
git checkout patch-1
git commit --amend
# (check the result)
git show
# (change the commit remotely)
git push --force-with-lease
By the way, are you familiar with using git locally?
Knowing how to amend commits would be helpful for contributing in general, but
if this seems too much, I can do the fix.
The result looks good.
The commit can be amended with: # (change the file manually)
# [...]
# (redo the commit with the new changes)
git add -u
git commit --amend
# (check the result)
git show
# (change the commit remotely)
git push --force-with-lease |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
softmaker-common.profile: add fstab to private-etc When using `private-etc`, app "forgets" it's product key and asks for license activation, despite it has already been done. Allow access to "/etc/fstab" to avoid it & related GUI error: The application cannot create a unique identifier. Please make sure the application has sufficient permissions. Fixes #5773.
Nitpick: The wording in the first paragraph is a bit strange; I'd change the
commit message to the following:
softmaker-common.profile: add fstab to private-etc
When using `private-etc`, the app "forgets" its product key and
asks for license activation, even though it had already been done.
Allow access to "/etc/fstab" to avoid it & the related GUI error:
The application cannot create a unique identifier.
Please make sure the application has sufficient permissions.
Fixes #5773.
(It can be amended with the same commands as in this comment)
Other than that, LGTM.
When using `private-etc`, the app "forgets" its product key and asks for license activation, even though it had already been done. Allow access to "/etc/fstab" to avoid it & the related GUI error: The application cannot create a unique identifier. Please make sure the application has sufficient permissions. Fixes #5773.
Done :-) Sorry about previous text version, I guess in exact such moments it becomes obvious that English isn't one's native language. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged, thanks! |
When using
private-etc
, app "forgets" it's product key andasks for license activation, despite it has already been done.
Allow access to "/etc/fstab" to avoid it & related GUI error:
Fixes #5773.