Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles: softmaker-common: add fstab to private-etc #5777

Merged
merged 1 commit into from
Apr 11, 2023
Merged

profiles: softmaker-common: add fstab to private-etc #5777

merged 1 commit into from
Apr 11, 2023

Conversation

hotcapy
Copy link
Contributor

@hotcapy hotcapy commented Apr 3, 2023

When using private-etc, app "forgets" it's product key and
asks for license activation, despite it has already been done.

Allow access to "/etc/fstab" to avoid it & related GUI error:

The application cannot create a unique identifier.
Please make sure the application has sufficient permissions.

Fixes #5773.

@hotcapy hotcapy changed the title softmaker-etc-fstab softmaker-common.profile: add fstab to private-etc Apr 3, 2023
Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(There are a few suggestions but I can't review at the moment; leaving this as
a placeholder)

Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Sorry for the delay)

Change the commit message to something like the following:

softmaker-common.profile: add fstab to private-etc

When using `private-etc`, SoftMaker Office "forgets" that it was activated
already & asks for product key again.

Allowing access to "/etc/fstab" fixes the following error:

    The application cannot create a unique identifier.
    Please make sure the application has sufficient permissions.

Fixes #5773.

Main changes:

  • Clarify in the title what the commit does
  • Indent error message by 4 spaces
  • Add "Fixes #XXX", which makes the issue be closed automatically when the PR
    is merged

See the following for details:

Amending the commit message can be done with:

# (change the commit locally)
git checkout patch-1
git commit --amend

# (check the result)
git show

# (change the commit remotely)
git push --force-with-lease

By the way, are you familiar with using git locally?

Knowing how to amend commits would be helpful for contributing in general, but
if this seems too much, I can do the fix.

@kmk3
Copy link
Collaborator

kmk3 commented Apr 6, 2023

hotcapy force-pushed the patch-1 branch from e747284 to 8fe750a

The result looks good.

Sort as per sort.py.

The commit can be amended with:

# (change the file manually)
# [...]

# (redo the commit with the new changes)
git add -u
git commit --amend

# (check the result)
git show

# (change the commit remotely)
git push --force-with-lease

Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

softmaker-common.profile: add fstab to private-etc

When using `private-etc`, app "forgets" it's product key and
asks for license activation, despite it has already been done.

Allow access to "/etc/fstab" to avoid it & related GUI error:

    The application cannot create a unique identifier.
    Please make sure the application has sufficient permissions.

Fixes #5773.

Nitpick: The wording in the first paragraph is a bit strange; I'd change the
commit message to the following:

softmaker-common.profile: add fstab to private-etc

When using `private-etc`, the app "forgets" its product key and
asks for license activation, even though it had already been done.

Allow access to "/etc/fstab" to avoid it & the related GUI error:

    The application cannot create a unique identifier.
    Please make sure the application has sufficient permissions.

Fixes #5773.

(It can be amended with the same commands as in this comment)

Other than that, LGTM.

When using `private-etc`, the app "forgets" its product key and
asks for license activation, even though it had already been done.

Allow access to "/etc/fstab" to avoid it & the related GUI error:

    The application cannot create a unique identifier.
    Please make sure the application has sufficient permissions.

Fixes #5773.
@hotcapy
Copy link
Contributor Author

hotcapy commented Apr 11, 2023

Done :-)

Sorry about previous text version, I guess in exact such moments it becomes obvious that English isn't one's native language.

Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmk3 kmk3 merged commit 0554f6d into netblue30:master Apr 11, 2023
@kmk3
Copy link
Collaborator

kmk3 commented Apr 11, 2023

Merged, thanks!

@hotcapy hotcapy deleted the patch-1 branch May 1, 2023 05:51
@kmk3 kmk3 changed the title softmaker-common.profile: add fstab to private-etc profiles: softmaker-common: add fstab to private-etc Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

freeoffice-textmaker: cannot create unique identifier
3 participants