Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles: nextcloud: add dbus-user.own & document dbus service #6211

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

glitsj16
Copy link
Collaborator

@glitsj16 glitsj16 commented Feb 16, 2024

Relates to:

Additional context:

Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically approved.

etc/profile-m-z/nextcloud.profile Outdated Show resolved Hide resolved
etc/profile-m-z/nextcloud.profile Outdated Show resolved Hide resolved
@rusty-snake
Copy link
Collaborator

Actually this PR weakens the D-Bus filter.

@glitsj16 glitsj16 changed the title nextcloud: harden D-Bus filtering nextcloud: D-Bus filtering changes Feb 16, 2024
@glitsj16
Copy link
Collaborator Author

@rusty-snake

  • changed the PR title to better express what it does
  • I'll revisit the wiki entrees ASAP

Thanks for your enlightening comments!

@glitsj16 glitsj16 merged commit 7ab8d45 into netblue30:master Feb 19, 2024
3 checks passed
@glitsj16 glitsj16 deleted the nextcloud-fix branch February 19, 2024 09:05
@kmk3
Copy link
Collaborator

kmk3 commented Feb 19, 2024

@glitsj16

Please use "squash and merge" by default again on future profile-only PRs, as
most of them are about a single logical change (and many of them contain
multiple amend/fixup commits, which add noise).

For example, this is the (simplified) git log of the recent relevant merges:

$ git log --oneline --graph --no-decorate f7e2c25730..44e241261e
* 44e241261 electron-cash: use new private-etc syntax
*   7ab8d45dc Merge pull request #6211 from glitsj16/nextcloud-fix
|\
| * b97e853a3 nextcloud: fix the comment link to the wiki FAQ
| * bc3968bb2 nextcloud: edit dbus comment as requested in review
| * 15fc09ec7 nextcloud: harden D-Bus filtering
*   2bca27a10 Merge pull request #6181 from haplo/electron-cash
|\
| * f0cfc70cc Blacklist ~/.electron-cash in disable-programs.inc
| * dae8e6991 electron-cash.profile
* 5954f72e9 Merge pull request #6180 from haplo/rawtherapee
* 84a5f1a60 rawtherapee.profile
$ git log --oneline --graph --no-decorate f7e2c25730..44e241261e | wc -l
12

With squashing, it would look something like this:

$ git log --oneline --graph --no-decorate aaaaaaaaaa~1..cccccccccc
* ccccccccc Profile for Electron Cash (#6181)
* bbbbbbbbb nextcloud: D-Bus filtering changes (#6211)
* aaaaaaaaa Profile for RawTherapee (#6180)
$ git log --oneline --graph --no-decorate aaaaaaaaaa~1..cccccccccc | wc -l
3

When in doubt feel free to ping me.

Related discussion: #6201

@glitsj16
Copy link
Collaborator Author

@kmk3

This flew under my radar before. Thanks for reminding me. I've just merged my wusc-fixes. Hope I got it right this time...

@kmk3 kmk3 changed the title nextcloud: D-Bus filtering changes profiles: nextcloud: add dbus-user.own & document dbus service Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants